refactor: create consistent interface for metrics exporters #11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chatton
commented
Oct 24, 2025
|
|
||
| return &Config{ | ||
| EvnodeAddr: flags.evnodeAddr, | ||
| EvmWSURL: flags.evmWSURL, |
There was a problem hiding this comment.
field seemed to be unused
chatton
commented
Oct 24, 2025
| } | ||
|
|
||
| func monitorAndVerifyDataAndHeaders(cmd *cobra.Command, args []string) error { | ||
| func monitorAndExportMetrics(_ *cobra.Command, _ []string) error { |
There was a problem hiding this comment.
renamed as purpose of tool has expanded
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR consolidates the patterns for creating metrics exporters by defining a new
metrics.Exporterinterface, moving the existing logic into separate implementations of this interface, and conditionally registering these types based on flags in the mainmonitorcommand.I also removed the
enableMetricsflag, as I think it doesn't really serve a purpose as the point of this tool is to export and expose metrics :D