Skip to content

EEI: transfer() method and simplification of selfDestruct()#113

Open
chfast wants to merge 2 commits intoewasm:masterfrom
chfast:eei-transfer
Open

EEI: transfer() method and simplification of selfDestruct()#113
chfast wants to merge 2 commits intoewasm:masterfrom
chfast:eei-transfer

Conversation

@chfast
Copy link
Copy Markdown
Collaborator

@chfast chfast commented Jul 25, 2018

Resolves #98.

@lrettig
Copy link
Copy Markdown
Member

lrettig commented Jul 25, 2018

I had a conversation with (I believe) @Arachnid at Ethereum Magicians where I used this method as an example of Ewasm departing from full EVM compatibility, and he indicated that it's dangerous and that the existing transfer mechanics are the way they are for a reason--something to do with the danger of transferring to a contract which is not designed to accept ETH, thus acting as a black hole for funds. It might be interesting to have that conversation here.

@chfast
Copy link
Copy Markdown
Collaborator Author

chfast commented Jul 25, 2018

I agree. This method is only needed for evm2wasm. I want it to be properly designed, then we can disable it in "pure ewasm" configurations.

@axic
Copy link
Copy Markdown
Member

axic commented Jul 30, 2018

Wouldn't you want to propose this PR in conjunction with changing selfDestruct at the same time?

@chfast
Copy link
Copy Markdown
Collaborator Author

chfast commented Jul 30, 2018

Wouldn't you want to propose this PR in conjunction with changing selfDestruct at the same time?

I can, but I wanted to propose a single change per PR for easier review.

@chfast chfast changed the title EEI: transfer() method EEI: transfer() method and simplification of selfDestruct() Jul 31, 2018
@chfast
Copy link
Copy Markdown
Collaborator Author

chfast commented Jul 31, 2018

Added selfDestruct() changes.

@chfast
Copy link
Copy Markdown
Collaborator Author

chfast commented Aug 22, 2018

Rebased.

@egroge
Copy link
Copy Markdown

egroge commented Sep 8, 2020

Hello, is this transfer method likely to be merged into eWASM? If not, what is the accepted way to transfer money between accounts in eWASM? Any links or explanations on this would be appreciated as I have not been able to find much about it so far.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Do not transfer ETH with selfDestruct

4 participants