Add additional test for ecadd with valid curve points#5
Open
jwasinger wants to merge 1 commit intoewasm:masterfrom
Open
Add additional test for ecadd with valid curve points#5jwasinger wants to merge 1 commit intoewasm:masterfrom
jwasinger wants to merge 1 commit intoewasm:masterfrom
Conversation
axic
force-pushed
the
ecadd-test
branch
2 times, most recently
from
2e754ff to
629bc15
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was writing some code to generate inputs for ecadd as benchmarking cases for https://github.com/jwasinger/wasm-benchmarking . Figured I would add a few of the points here to expand test coverage (the unit tests for ecadd do not currently explicitly test for valid points on the curve).