Open
Conversation
Co-authored-by: poemm <36397285+poemm@users.noreply.github.com>
jwasinger
force-pushed
the
f6m_mul_native
branch
from
0dae7b2 to
5e95642
Compare
jwasinger
force-pushed
the
f6m_mul_native
branch
from
af3df91 to
9735ad8
Compare
chfast
reviewed
Aug 12, 2020
| auto start = std::chrono::system_clock::now(); | ||
|
|
||
| for (auto i = 0; i < 1350; i++) { | ||
| result = p1.Mul(p2); |
There was a problem hiding this comment.
It may be too easy to figure out that Mul always produce the same result or result is discarded. Make sure, Mul() is compiled in separate file. I.e. fix https://github.com/ewasm/evm384_f6m_mul/pull/4/files#diff-7a5bec3042d5d314cdc3d35cd7a2411dR1.
| int main(int argc, char **argv) { | ||
| F6 p1 { | ||
| .a = { | ||
| .x = F1(intx::from_string<intx::uint512>("0x0daa35e7a880a2ca3bcea128c5c8d17202945981a13aec134d10c051c1fa23c06b3088c3a380f4b8b1f598e5f390298f")), |
There was a problem hiding this comment.
Suggested change
| .x = F1(intx::from_string<intx::uint512>("0x0daa35e7a880a2ca3bcea128c5c8d17202945981a13aec134d10c051c1fa23c06b3088c3a380f4b8b1f598e5f390298f")), | |
| .x = F1(0x0daa35e7a880a2ca3bcea128c5c8d17202945981a13aec134d10c051c1fa23c06b3088c3a380f4b8b1f598e5f390298f_u512), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.