Open
Conversation
Member
|
Thanks for this! How about creating a new directory, blake2f, and leaving the old one as-is? |
axic
force-pushed
the
eip152-blake2
branch
2 times, most recently
from
710116f to
d17713c
Compare
axic
reviewed
May 12, 2020
blake2f/src/f.rs
Outdated
| /// Implementation of blake2 compression function F. | ||
| /// | ||
| /// This was copied from https://gist.github.com/seunlanlege/fa848401d316c52919f6e554fba6870b | ||
| /// with some modifications. It was initially written by Seun Lanlege and has no explicit license. |
Member
There was a problem hiding this comment.
Oh only noticed this now. Could you ask him on the gist to license it under Apache-2.0 or MIT or something like that?
Member
|
This looks great, would be ready to merge, apart from that small question on |
Author
|
Does the license look good? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #36
This PR adds support for EIP152. Each test case described in the document is passing and benchmarking on my personal laptop suggests this is fast enough.
The 1200 round compression benchmarks provided in the document were ran on a Intel(R) Core(TM) i7-7920HQ CPU @ 3.10GHz and averaged ~20000ns. Comparatively, 1200 round compression benchmarks on my Intel(R) Core(TM) i7-8550U CPU @ 1.80GHz averaged ~40000ns. This seems reasonable.