Skip to content

debug_log and debug_mem#2

Open
cdetrio wants to merge 1 commit intoewasm:masterfrom
cdetrio:debug-mem
Open

debug_log and debug_mem#2
cdetrio wants to merge 1 commit intoewasm:masterfrom
cdetrio:debug-mem

Conversation

@cdetrio
Copy link
Copy Markdown

@cdetrio cdetrio commented Aug 12, 2019

Two debug methods I've been using. Don't merge until we standardize the debug methods we want on both scout.rs and scout.ts.


let mem: WebAssembly.Memory
let res: Buffer
res = Buffer.alloc(32)
Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This prevents a crash if eth2_savePostStateRoot is never called (cli.ts crashes if res is undefined).

@s1na
Copy link
Copy Markdown
Collaborator

s1na commented Aug 14, 2019

Should we maybe go with this debug API? ewasm-rust-api has also support for it. We'd have to drop the printStorage methods however.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants