feat(rescheduling): gpuFragmentation eligible by default + env kill switch - #13
Merged
Merged
Conversation
…ck-eligible=false opts out
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Two changes to the
gpuFragmentationrepack strategy:exa.ai/repack-eligible=true; now every pod is eligible by default, and settingexa.ai/repack-eligible=falseexcludes it:EXA_GPU_REPACK_DISABLED=trueon the scheduler process makes the strategy return no victims, independent of the scheduler configmap:All other safety gates are unchanged and still bound the blast radius: only negative-priority pods (
maxVictimPriority: -1default — priority ≥ 0 is never touched), sole GPU pod on its node, controller-owned, single-member PodGroup, nokarpenter.sh/do-not-disrupt, strictly fuller feasible destination, pool cooldown, per-PodGroup eviction cap, and one victim per pool per pass.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Behavioral widening: after rollout, any negative-priority sole-GPU pod becomes repackable without labeling. Workloads that must never be repacked should set
exa.ai/repack-eligible=false(or a priority class ≥ 0, orkarpenter.sh/do-not-disrupt). Unit tests updated: unlabeled pod is now selected;=falseis skipped; 14/14 pass.Does this PR introduce a user-facing change?
Link to Devin session: https://app.devin.ai/sessions/6351ff07ed074c55a521b26d6af34c1b
Requested by: @pfernandes21