feat(plugins): capacitytiers — ordered capacity-tier gang scheduling - #14
Closed
pfernandes21 wants to merge 1 commit into
Closed
feat(plugins): capacitytiers — ordered capacity-tier gang scheduling#14pfernandes21 wants to merge 1 commit into
pfernandes21 wants to merge 1 commit into
Conversation
PodGroups opting in via exa.ai/capacity-tiers get a durable tier clock (annotations patched on the PodGroup) and a hard predicate pinning the whole gang to nodes whose karpenter.sh/capacity-type matches the tier in force; acquiring gangs advance to the next tier after the per-tier budget (exa.ai/tier-fallback-seconds, default 300s) expires. Assisted-by: Devin:claude-opus-4-6
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
|
Superseded: gang capacity selection is moving to static pod specs in exa_flyte (mixed reserved+spot gangs, same-AZ required, reserved preferred) with the exa-scale first-workload latch covering assembly time — no Volcano plugin needed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds a new
capacitytiersscheduler plugin implementing reserved-first spot fallback natively in Volcano (Phase 1 of the gang capacity-preference design). A PodGroup opts in with an ordered tier list; the plugin keeps the whole gang homogeneous on one capacity type at a time and advances tiers on a durable clock:exa.ai/capacity-tiers: "reserved,spot"— ordered node capacity types (values ofkarpenter.sh/capacity-type)exa.ai/tier-fallback-seconds: "300"— per-tier acquisition budget (default 300s; malformed values fail closed to the default)exa.ai/capacity-tier— tier currently in forceexa.ai/capacity-tier-since— RFC3339 tier entry timePer session open, for each opted-in job:
A hard
PredicateFn(UnschedulableAndUnresolvable) then rejects any node whosekarpenter.sh/capacity-typelabel (key overridable via plugin argumentcapacitytiers.nodeLabelKey) differs from the gang's current tier — so all-or-nothing gang admission via the existing gang plugin + Statement commit/discard can never produce a mixed reserved/spot gang. The clock freezes once the gang is Running; non-opted-in jobs are untouched. Malformed tier lists log and leave the gang unrestricted (predicate not applied), matching pre-plugin behavior.Uses the same PodGroup patch RBAC already granted for gpuFragmentation stamping (#11).
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Deployment wiring (scheduler config tier, PodGroup annotations from exa_flyte, chart pin) lands separately in the monorepo. Unit tests cover annotation parsing/validation, tier resolution (fresh entry, budget expiry, last-tier hold, frozen clock when running), and session-level predicate behavior via
uthelperfake sessions.Does this PR introduce a user-facing change?
Link to Devin session: https://app.devin.ai/sessions/100be51de8b84c958695756c345708b9
Requested by: @pfernandes21