feat(rescheduling): optional crossPool mode for gpuFragmentation - #18
Merged
Merged
Conversation
With crossPool enabled every GPU node forms one candidate set: the workload's own node selection (nodeSelector, required affinity, taints), evaluated through the session predicates, is the only placement filter. Unlabeled nodes are included, and the cooldown clock and one-drain-per-pass budget apply cluster-wide. Default remains per-pool. Assisted-by: devin:claude
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
Adds an opt-in
crossPoolflag (defaultfalse) to thegpuFragmentationrescheduling strategy. Today candidate sources/destinations are grouped perkarpenter.sh/nodepool, so consolidation never crosses a pool boundary and unlabeled (e.g. on-prem) nodes are invisible.With
crossPool: true:poollabel become cluster-wide (label valuecross-pool).Planner change is confined to the grouping loop:
Everything downstream (FFD simulation over cloned idle capacity, fractional-fullness destination ordering, atomic move sets, priority ceiling/tie-break, per-PodGroup eviction caps, stamping) is unchanged. Default behavior with
crossPool: falseis byte-for-byte the existing per-pool behavior.Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
go test ./pkg/scheduler/plugins/rescheduling/...passes;go vet/gofmtclean.Does this PR introduce a user-facing change?
Link to Devin session: https://app.devin.ai/sessions/9f5f310b988c4566869471b54b1154dd
Open in Devin Desktop: https://app.devin.ai/desktop/session/9f5f310b988c4566869471b54b1154dd?variant=devin
Requested by: @pfernandes21