[EAK-654] Improve config change event handling#655
Open
smiakchilo wants to merge 6 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses Issue #654 by making ConfigChangeListener more resilient to transient “missing resource” situations in clustered AEMaaCS author environments, reducing the risk of incorrectly treating a changed config as removed.
Changes:
- Added configurable “resolve-with-retry” behavior for resolving changed resources before deciding to reset configuration.
- Refactored async processing to use scheduled executors and improved shutdown handling.
- Expanded and refactored unit tests (moving away from Mockito in several cases) and added coverage for additional reset/update scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
core/src/main/java/com/exadel/aem/toolkit/core/configurator/services/ConfigChangeListener.java |
Adds resolve-with-retry and reorganizes async execution/shutdown behavior for change processing. |
core/src/main/java/com/exadel/aem/toolkit/core/configurator/services/ConfigChangeListenerConfiguration.java |
Introduces OSGi config knobs for retry count and delay. |
core/src/test/java/com/exadel/aem/toolkit/core/configurator/services/ConfigChangeListenerTest.java |
Updates tests to use stubs and adds scenarios around update/reset behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #654