Skip to content

[EAK-654] Improve config change event handling#655

Open
smiakchilo wants to merge 6 commits into
feature/EAK-651from
bugfix/EAK-654
Open

[EAK-654] Improve config change event handling#655
smiakchilo wants to merge 6 commits into
feature/EAK-651from
bugfix/EAK-654

Conversation

@smiakchilo

Copy link
Copy Markdown
Collaborator

Fixes #654

@smiakchilo smiakchilo added bug Something isn't working AEM AEM-specific competencies are involved labels May 19, 2026
@smiakchilo smiakchilo changed the base branch from master to feature/EAK-651 May 19, 2026 11:48
@smiakchilo smiakchilo requested a review from Copilot May 19, 2026 11:48

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR addresses Issue #654 by making ConfigChangeListener more resilient to transient “missing resource” situations in clustered AEMaaCS author environments, reducing the risk of incorrectly treating a changed config as removed.

Changes:

  • Added configurable “resolve-with-retry” behavior for resolving changed resources before deciding to reset configuration.
  • Refactored async processing to use scheduled executors and improved shutdown handling.
  • Expanded and refactored unit tests (moving away from Mockito in several cases) and added coverage for additional reset/update scenarios.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 5 comments.

File Description
core/src/main/java/com/exadel/aem/toolkit/core/configurator/services/ConfigChangeListener.java Adds resolve-with-retry and reorganizes async execution/shutdown behavior for change processing.
core/src/main/java/com/exadel/aem/toolkit/core/configurator/services/ConfigChangeListenerConfiguration.java Introduces OSGi config knobs for retry count and delay.
core/src/test/java/com/exadel/aem/toolkit/core/configurator/services/ConfigChangeListenerTest.java Updates tests to use stubs and adds scenarios around update/reset behavior.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

AEM AEM-specific competencies are involved bug Something isn't working

Projects

Development

Successfully merging this pull request may close these issues.

[EAK-654] Config change event is sometimes mishandled in cluster environment

2 participants