minor fix: Dark Mode Toggle#626
Open
deve-sh wants to merge 1 commit intoexcalidraw:masterfrom
Open
Conversation
The toggle previously took a couple of clicks on production to reflect the correct state. This was due to a bug in the underlying gatsby-plugin-dark-mode plugin This commit works around the issue.
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toggle previously took a couple of clicks on production (or a local build) to reflect the correct state (Check the attached video recording). To reproduce, open blog.excalidraw.com in an incognito window and try clicking the dark mode toggle.
Excalidraw.Blog.Dark.Mode.toggle.bug.mp4
This was due to a bug in the underlying
gatsby-plugin-dark-modeplugin.This commit works around the issue using this update.
Ref issues and code snippets:
insin/gatsby-plugin-dark-mode#13
TimTree/games-by-tim#1