feat: add mute/unmute toggle for pencil stroke sounds#25
Open
sachinsmc wants to merge 2 commits intoexcalidraw:mainfrom
Open
feat: add mute/unmute toggle for pencil stroke sounds#25sachinsmc wants to merge 2 commits intoexcalidraw:mainfrom
sachinsmc wants to merge 2 commits intoexcalidraw:mainfrom
Conversation
Adds a sound toggle button to the toolbar that persists preference via localStorage (default: muted). In fullscreen, the button adopts Excalidraw's native island styling for visual consistency.
|
@sachinsmc is attempting to deploy a commit to the Excalidraw Team on Vercel. A member of the Team first needs to authorize it. |
|
Hi! Someone please review/approve this |
# Conflicts: # src/global.css # src/mcp-app.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
localStorage(default: muted)--island-bg-color,--default-border-color,--shadow-islandCSS variables) for visual consistency with the Export buttonChanges
src/pencil-audio.ts— AddedisMuted(),toggleMute()exports with localStorage persistence (excalidraw:mutedkey). Default state is muted.playStroke()now checks mute flag before playing.src/mcp-app.tsx— AddedSoundOnIcon/SoundOffIconSVG components and mute button to toolbar. Toolbar always renders (mute button in both modes, fullscreen button only in inline mode).src/global.css— Shared button styles for.fullscreen-btnand.mute-btn. Fullscreen-specific overrides: always-visible toolbar, native Excalidraw island styling for the mute button.