feat(app): add selection-aware comments in fullscreen#58
Open
aryeko wants to merge 1 commit intoexcalidraw:mainfrom
Open
feat(app): add selection-aware comments in fullscreen#58aryeko wants to merge 1 commit intoexcalidraw:mainfrom
aryeko wants to merge 1 commit intoexcalidraw:mainfrom
Conversation
|
@aryeko is attempting to deploy a commit to the Excalidraw Team on Vercel. A member of the Team first needs to authorize it. |
f7d57f9 to
5090834
Compare
Author
|
@antonpk1 Any chance you can have a look? I think this feature will be very useful and make will make excelidraw mcp more usable and advanced than others (eg draw.io) If the refactor is too much I can focus the pr to the functionality only |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds selection-aware follow-up editing to the fullscreen Excalidraw widget, so users can point the model at specific diagram elements instead of only giving whole-diagram feedback.
It introduces:
Commentactions for selected elementsProblem
Today users can manually edit diagrams in fullscreen, but they cannot easily tell the model “this box” or “these two nodes” when asking for follow-up changes. That makes iterative refinement much less precise.
What Changed
Selection-aware context
Anchored comments
Commentaffordance near the current selectionui/messageandui/update-model-contextWidget context refactor
updateModelContextEditor/persistence cleanup
Why This Is Useful
This makes the app feel much more conversational and iterative:
Try It
Example follow-ups once the diagram is open in fullscreen:
Auth Serviceelement and ask:use greenmake this label cleareralign these and add spacingDemo
Testing
Ran:
npm testnpm run buildAdded tests for:
Verified
Verified manually:
Commentopens the anchored composer near the selectionNotes
Happy to split this if maintainers would prefer the selection badge, widget-context refactor, and anchored comments to land separately.