fix(parser): support Mermaid v11 subgraph IDs and parse newlines correctly#98
Open
tamld wants to merge 1 commit intoexcalidraw:masterfrom
Open
fix(parser): support Mermaid v11 subgraph IDs and parse newlines correctly#98tamld wants to merge 1 commit intoexcalidraw:masterfrom
tamld wants to merge 1 commit intoexcalidraw:masterfrom
Conversation
|
@tamld is attempting to deploy a commit to the Excalidraw Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses two compatibility bugs when parsing Mermaid v11 flowcharts into Excalidraw:
flowchart-prefix into subgraph DOM IDs (e.g.,flowchart-sub1-52), which caused the exact match[id='...']insrc/parser/flowchart.tsto fail. This is fixed by using a substring match[id*='...'].\\nand<br>tags inside Mermaid element labels.entityCodesToTextinsrc/utils.tshas been updated to translate these tags into real newlines, ensuring text wraps correctly inside Excalidraw shapes instead of squashing onto a single line.Motivation
When working with AAOS and programmatic diagram generation, complex subgraphs and multiline labels are essential. This ensures the output remains as editable native shapes rather than falling back to an uneditable SVG image blob.