Fix billing downgrade recharge and suspension race#2397
Draft
niemyjski wants to merge 7 commits into
Draft
Conversation
…to issue/billing-downgrade-race # Conflicts: # src/Exceptionless.Core/Billing/StripeEventHandler.cs
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PlanChangedpublication without repeating provider mutations.IStripeBillingClientsurface.Root cause
Paid-to-free changes immediately canceled the active subscription without proration. A later upgrade therefore created a new full-price subscription without credit for unused time. Asynchronous deletion/update webhooks could also overwrite the free or newly paid state because billing writes were neither serialized nor correlated to the controlling subscription and operation.
Verification
dotnet build tests/Exceptionless.Tests/Exceptionless.Tests.csproj --no-restore --disable-build-servers -m:1— 0 warnings, 0 errorsBillingLifecycleEndpointTests— 143/143 passed101b6d236) — API health 200 and locally HMAC-signedlivemode:falsewebhook 200api.stripe.comtelemetry search returned no spansBreaking changes
None. The original
BillingManagerandStripeEventHandlerpublic constructors remain available.