Adding network.wait_for_idle options#47
Merged
excid3 merged 3 commits intoexcid3:mainfrom Feb 15, 2025
higher-pixels:wait-for-idle-options
Merged
Adding network.wait_for_idle options#47excid3 merged 3 commits intoexcid3:mainfrom higher-pixels:wait-for-idle-options
excid3 merged 3 commits intoexcid3:mainfrom
higher-pixels:wait-for-idle-options
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@excid3 Thanks for this gem! I'm converting our application to use this, however, I ran into an issue that requires
page.go_to(url)to callpage.network.wait_for_idleto allow in-page JavaScript processing to finish. As such, I made a few changes and would appreciate your review, feedback, and consideration.This PR:
page.network.wait_for_idleoutside thebrowser.create_pageif...elseblock so that both cases can make use of itwait_for_idle_optionsnamed parameter torender_pdfto allow setting all of the availablenetwork.wait_for_idleoptionsensurewithpage.closeto clean up network connectionsauthorizehash to**authorizeinbrowser.create_page