fix: include tests/ (and tox.ini) in the flit sdist - #420
Open
BetterAndBetterII wants to merge 2 commits into
Open
fix: include tests/ (and tox.ini) in the flit sdist#420BetterAndBetterII wants to merge 2 commits into
BetterAndBetterII wants to merge 2 commits into
Conversation
Fixes executablebooks#261 — flit_core sdists omitted the test suite while shipping tox.ini, so distro packagers could not run the project's tests from the PyPI source tarball. Explicitly include tests/ and tox.ini; keep docs/ and benchmarking/ excluded.
for more information, see https://pre-commit.ci
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tox.inibut omittedtests/, so distro packagers could not run the project's tests from the source tarball.flit_core's default file set does not pull in VCS extras the way fullflitdoes, andtests/was also listed under[tool.flit.sdist] exclude. Explicitlyincludetests/andtox.ini; keepdocs/andbenchmarking/excluded.Test plan
python -m build --sdistand confirm the tarball containstests/(44 files) andtox.inipytest tests/test_packaging/test_sdist_includes_tests.py