🐛 FIX: Nested field lists incorrectly nesting inside parent containers#139
Merged
Conversation
Field lists inside list items (or other indented containers) would recursively nest each field inside the previous one, instead of being siblings. The body-indent scanner compared `tShift` against 0, which doesn't account for the parent block's indentation (`blkIndent`). Changed the check to `state.tShift[_line] <= state.blkIndent` so the comparison is relative to the containing block's indent. Fixes executablebooks/MyST-Parser#1108
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #139 +/- ##
==========================================
- Coverage 92.80% 92.68% -0.12%
==========================================
Files 31 38 +7
Lines 1835 2257 +422
==========================================
+ Hits 1703 2092 +389
- Misses 132 165 +33
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Field lists inside list items (or other indented containers) would recursively nest each field inside the previous one, instead of being siblings. The body-indent scanner compared
tShiftagainst 0, which doesn't account for the parent block's indentation (blkIndent).Changed the check to
state.tShift[_line] <= state.blkIndentso the comparison is relative to the containing block's indent.Fixes executablebooks/MyST-Parser#1108