Bind mount the directory with SSH keys #12
+541
−304
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadorovsky
force-pushed
the
libcontainer
branch
2 times, most recently
from
e6b848e to
d4ff284
Compare
Drop the dependency on container engines like Docker or Podman by using youki's `libcontainer` and `oci-spec` crates to run rootless containers, while keeping all the logic doing that in our binary. That solves the major problem we had with Docker - file ownership in bind mounted volumes - where new files created inside container in a volume with source code were owned by `root` and therefore inaccessible for a regular user calling `icedragon`. After this change, regular container engines are still used for building the images. Fixes #7
vadorovsky
force-pushed
the
libcontainer
branch
from
d4ff284 to
fb41d71
Compare
Otherwise CI doesn't run on stacked PRs.
That allows to build Rust crates with private repositories as dependencies. Fixes #6
vadorovsky
force-pushed
the
ssh-keys
branch
2 times, most recently
from
6ecc3d8 to
9218921
Compare
vadorovsky
force-pushed
the
libcontainer
branch
from
fb41d71 to
e9843a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That allows to build Rust crates with private repositories as dependencies.
Fixes #6
This change is