Refresh popup data when opening module popups#2988
Open
eyupcanakman wants to merge 1 commit intoexelban:masterfrom
Open
Refresh popup data when opening module popups#2988eyupcanakman wants to merge 1 commit intoexelban:masterfrom
eyupcanakman wants to merge 1 commit intoexelban:masterfrom
Conversation
- Prime popup readers when reopened\n- Replay cached values for non-popup readers when popup opens\n- Add reader lifecycle regression tests for reopen and replay behavior
jestfortest
approved these changes
Feb 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Fixes #2140.
With higher update intervals, popup values could stay stale until the next scheduled update.
Test plan
xcodebuild -project Stats.xcodeproj -scheme Stats -destination 'platform=macOS' -derivedDataPath /tmp/stats-dd test -only-testing:Tests CODE_SIGNING_ALLOWED=NOxcodebuild -project Stats.xcodeproj -scheme Stats -destination 'platform=macOS' -configuration Release -derivedDataPath /tmp/stats-dd archive CODE_SIGNING_ALLOWED=NO