Fix Apple Silicon power readings scaling with update interval#3018
Open
eyupcanakman wants to merge 1 commit intoexelban:masterfrom
Open
Fix Apple Silicon power readings scaling with update interval#3018eyupcanakman wants to merge 1 commit intoexelban:masterfrom
eyupcanakman wants to merge 1 commit intoexelban:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2777
Summary
On Apple Silicon, CPU, GPU, ANE, RAM, and PCI power readings increased with the selected update interval because the Sensors reader treated the raw
IOReportenergy delta as a power value.Convert the delta to power by dividing it by the elapsed time between samples. Keep the existing first-read behavior and update the sample timestamp when a read returns no power value.
Testing
swiftlint lint --no-cachexcodebuild -project Stats.xcodeproj -scheme Stats -destination platform=macOS -derivedDataPath /tmp/stats-dd-2777 test -only-testing:Tests CODE_SIGNING_ALLOWED=NOxcodebuild -project Stats.xcodeproj -scheme Stats -destination platform=macOS -configuration Release -derivedDataPath /tmp/stats-dd-2777 archive CODE_SIGNING_ALLOWED=NO