Add support for specifying CAA records #53
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vanillajonathan
approved these changes
Jun 4, 2025
This allows specifying which CA authorities are allowed to issue
certificates for subdomains or disallow issuing certificates entirely.
This is disabled by default and is intended for situations where having
valid TLS certificates is not necessary and it's not desirable to have a
malicious IP (eg. phishing site) potentially appear more legitimate due
to the valid certificate.
This commit includes a couple minor fixes:
- _get_env_splitted() now calls split(..., 1) instead of split(..., 2),
which actually produces up to 3 parts.
- The individual _write("END") calls in various qtype handlers were
replaced by a single write_end() call at the end of run()'s loop.
Contributor
Author
|
Thanks for reviewing the PR! I saw you committed a few fixes in |
vanillajonathan
merged commit c892748
into
exentriquesolutions:master
0 of 5 checks passed
Collaborator
|
Thank you for your contribution! |
abbierwolf
pushed a commit
to abbierwolf/nip.io
that referenced
this pull request
Aug 15, 2025
This allows specifying which CA authorities are allowed to issue
certificates for subdomains or disallow issuing certificates entirely.
This is disabled by default and is intended for situations where having
valid TLS certificates is not necessary and it's not desirable to have a
malicious IP (eg. phishing site) potentially appear more legitimate due
to the valid certificate.
This commit includes a couple minor fixes:
- _get_env_splitted() now calls split(..., 1) instead of split(..., 2),
which actually produces up to 3 parts.
- The individual _write("END") calls in various qtype handlers were
replaced by a single write_end() call at the end of run()'s loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows specifying which CA authorities are allowed to issue certificates for subdomains or disallow issuing certificates entirely. This is disabled by default and is intended for situations where having valid TLS certificates is not necessary and it's not desirable to have a malicious IP (eg. phishing site) potentially appear more legitimate due to the valid certificate.
This commit includes a couple minor fixes:
_get_env_splitted()now callssplit(..., 1)instead ofsplit(..., 2), which actually produces up to 3 parts._write("END")calls in various qtype handlers were replaced by a singlewrite_end()call at the end ofrun()'s loop.