Skip to content

Add practice exercise split-second-stopwatch #1569

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 11, 2025

Conversation

jiegillet
Copy link
Contributor

Brand new exercise!

I have been using Cursor for a little while, and I must say that this really helps with implementing tests like that. You make one change in the test files, tab-tab-tab and all the next ones change as well. You gotta be careful, but it really saves time. It also pretty much implemented the solution without me really asking for it. Pretty interesting experience.

Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps

    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)
  • Any exercise changed

    • 👤 Does the author of the PR need to be added as an author or contributor in <exercise>/.meta/config.json (see docs)?
    • 🔬 Do the analyzer and the analyzer comments exist for this exercise? Do they need to be changed?
    • 📜 Does the design file (<exercise>/.meta/design.md) need to be updated to document new implementation decisions?
  • Practice exercise changed

    • 🌲 Do prerequisites, practices, and difficulty in config.json need to be updated?
    • 🧑‍🏫 Are the changes in accordance with the community-wide problem specifiations?
  • Practice exercise tests changed

    • ⚪️ Are all tests except the first one skipped?
    • 📜 Does <exercise>/.meta/tests.toml need updating?

Automated comment created by PR Commenter 🤖.

@jiegillet
Copy link
Contributor Author

Oh no! I forgot that Duration was only introduced in Elixir 1.17, we need to support from 1.13.
I'll think of some other way to implement it, maybe using Time, but not today, so I'll set this back to draft.

@jiegillet jiegillet marked this pull request as draft May 10, 2025 13:41
@jiegillet jiegillet marked this pull request as ready for review May 11, 2025 01:14
@jiegillet
Copy link
Contributor Author

Done. Using Time actually made the code cleaner.

Copy link
Contributor

@neenjaw neenjaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neenjaw neenjaw added x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) labels May 11, 2025
@jiegillet jiegillet merged commit c6fbc82 into main May 11, 2025
8 of 9 checks passed
@jiegillet jiegillet deleted the jie-split-second-stopwatch branch May 11, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants