Skip to content

Mark Scale Generator as deprecated #1570

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 13, 2025

Conversation

IsaacG
Copy link
Member

@IsaacG IsaacG commented May 13, 2025

No description provided.

Copy link
Contributor

Thank you for contributing to exercism/elixir 💜 🎉. This is an automated PR comment 🤖 for the maintainers of this repository that helps with the PR review process. You can safely ignore it and wait for a maintainer to review your changes.

Based on the files changed in this PR, it would be good to pay attention to the following details when reviewing the PR:

  • General steps
    • 🏆 Does this PR need to receive a label with a reputation modifier (x:size/{tiny,small,medium,large,massive})? (A medium reputation amount is awarded by default, see docs)

Automated comment created by PR Commenter 🤖.

@neenjaw
Copy link
Contributor

neenjaw commented May 13, 2025

@IsaacG can you add some description to the PR with the rationale?

@neenjaw neenjaw added x:size/tiny Tiny amount of work x:rep/tiny Tiny amount of reputation labels May 13, 2025
@IsaacG
Copy link
Member Author

IsaacG commented May 13, 2025

@IsaacG can you add some description to the PR with the rationale?

It's deprecated in the problem specs ;) This just syncs that.

See exercism/problem-specifications#2343 for the PR that deprecated Scale Generator in the problem specs.

@neenjaw
Copy link
Contributor

neenjaw commented May 13, 2025

I don't follow every change on the problem specs repo ;) The explain is a nice curtesy, thanks!

@IsaacG
Copy link
Member Author

IsaacG commented May 13, 2025

You're very welcome.

I'm pretty sure the failing link checker isn't related to this PR.

Note, I don't have merge permission on this repo.

@neenjaw neenjaw merged commit 77934df into exercism:main May 13, 2025
8 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:rep/tiny Tiny amount of reputation x:size/tiny Tiny amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants