-
-
Notifications
You must be signed in to change notification settings - Fork 115
Add relative-distance
#752
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
jiegillet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yeah, I remember writing down that list was a pain :D
Well done, nice work!
exercises/practice/relative-distance/.meta/src/RelativeDistance.example.elm
Outdated
Show resolved
Hide resolved
exercises/practice/relative-distance/.meta/src/RelativeDistance.example.elm
Outdated
Show resolved
Hide resolved
exercises/practice/relative-distance/.meta/src/RelativeDistance.example.elm
Outdated
Show resolved
Hide resolved
config.json
Outdated
| "maybe" | ||
| ], | ||
| "prerequisites": [ | ||
| "dict" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's just practice dict on this one.
For prerequisites, let's add:
- maybe
- lists
- set
- recursion
- pattern matching
maybe tail-call-recursion once #751 is sorted out?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The prerequisites seem fine. However, this seems solvable without knowing sets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Your solution uses sets. And in general, I would suggest for students to know about sets before they try this one, because it can really help.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I added everything but recursion since I didn't see it in the repo as an existing concept. I wasn't sure if that meant students couldn't unlock the exercise until that concept is added.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It was added after you opened your PR. If you merge main now, you'll see it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.
jiegillet
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thank you again!
If you could merge main and add the recursion prerequisite, that would be great!
2c48061 to
cb363ba
Compare
Closes #739. Building up the graph of connections took a while :)