Sync problem specs #753
Merged
Sync problem specs #753
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jiegillet
approved these changes
Jun 9, 2025
Contributor
jiegillet
left a comment
jiegillet
left a comment
There was a problem hiding this comment.
Thank you, looks good.
I must ask, should we consider changing largest-series-product so that it returns errors instead of a maybe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are the results of running
./bin/configlet sync --docs --metadata --tests include -uy. The two newlargest-series-producttests just change the expected error messages for those two situations, but the track expectsNothingreturned, so there's no need to update the tests themselves.