-
-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow for custom test class names #41
Conversation
Hello. Thanks for opening a PR on Exercism 🙂 We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in. You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch. If you're interested in learning more about this auto-responder, please read this blog post. Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it. |
I don't know enough groovy to do more than reopening this pr. If you have not done so already you might find some better informed maintainers on the forums. |
The only Groovy code is an equivalent of |
Co-authored-by: Glenn Jackman <[email protected]>
tests/example-custom-class/gradlew
Outdated
@@ -0,0 +1,183 @@ | |||
#!/usr/bin/env sh |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any particular reason this uses sh and not bash?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤷 gradlew
is a wrapper file generated by Gradle; I just copied and pasted the existing one from other directories.
But your question got me wondering if we need any gradle files in the tests/
subfolders - as the test runner uses Maven, not Gradle. Let me try removing the wrappers with build.gradle
files - it might be just some remaining artifacts from earlier development.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it indeed is:
- artamonovkirill@2b536e5 added the gradle files
- artamonovkirill@2b536e5 later switched to maven
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally without gradle files - it works, as expected; push the commit to this PR
Co-authored-by: Isaac Good <[email protected]>
@IsaacG sorry I didn't mention anywhere that |
Not a big deal :) |
Approved. Let me know if you lack merge permissions and need help. |
Thank you 🙌 I indeed do not have merge permissions 😞 |
Not all tests are executed (the
@Ignore
annotation is not removed) if the test class name is different from the slug name. For example, forlinked-list
the expected slug-based test class name isLinkgedListSpec
, and the actual test class name isDoubleLinkedListSpec
This PR changes the logic to try fetching the class name from
.meta/config.json
first and fall back to the slug-derived test class name if it fails.Similar to exercism/scala-test-runner#38