Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump JDK to 17 #42

Closed
wants to merge 1 commit into from
Closed

Conversation

artamonovkirill
Copy link
Contributor

@artamonovkirill artamonovkirill commented Jan 18, 2025

The latest available stable openJDK (since it has been deprecated

Before:

exercism/groovy-test-runner latest b2195c6ba555 9 minutes ago 487MB

After:

exercism/groovy-test-runner latest 385e423671b9 25 minutes ago 468MB

./bin/run-reference-solution-tests-in-docker.sh
#0 building with "desktop-linux" instance using docker driver

#1 [internal] load build definition from Dockerfile
#1 transferring dockerfile: 754B done
#1 DONE 0.0s

#2 [internal] load metadata for docker.io/library/maven:3.8.5-openjdk-17
#2 ...

#3 [auth] library/maven:pull token for registry-1.docker.io
#3 DONE 0.0s

#4 [internal] load metadata for docker.io/library/maven:3.8.5-openjdk-17-slim
#4 DONE 1.1s

#2 [internal] load metadata for docker.io/library/maven:3.8.5-openjdk-17
#2 DONE 1.1s

#5 [internal] load .dockerignore
#5 transferring context: 121B done
#5 DONE 0.0s

#6 [cache 1/5] FROM docker.io/library/maven:3.8.5-openjdk-17@sha256:3a9c30b3af6278a8ae0007d3a3bf00fff80ec3ed7ae4eb9bfa1772853101549b
#6 DONE 0.0s

#7 [stage-1 1/6] FROM docker.io/library/maven:3.8.5-openjdk-17-slim@sha256:502e781d39f0b40fbd02eb23f5b7663618b76ba52034da218c64e92f6c5647be
#7 DONE 0.0s

#8 [internal] load build context
#8 transferring context: 23.32kB 0.0s done
#8 DONE 0.0s

#9 [stage-1 2/6] WORKDIR /opt/test-runner
#9 CACHED

#10 [stage-1 3/6] RUN apt-get update &&     apt-get install -y jq &&     apt-get purge --auto-remove -y &&     apt-get clean &&     rm -rf /var/lib/apt/lists/*
#10 CACHED

#11 [cache 2/5] WORKDIR /opt/exercise
#11 CACHED

#12 [cache 3/5] COPY src/ src/
#12 CACHED

#13 [cache 4/5] COPY pom.xml .
#13 CACHED

#14 [cache 5/5] RUN mvn test dependency:go-offline -DexcludeReactor=false
#14 CACHED

#15 [stage-1 4/6] COPY . .
#15 DONE 0.0s

#16 [stage-1 5/6] COPY --from=cache /root/.m2 /root/.m2
#16 DONE 0.5s

#17 [stage-1 6/6] COPY --from=cache /opt/exercise/pom.xml /root/pom.xml
#17 DONE 0.0s

#18 exporting to image
#18 exporting layers 0.1s done
#18 writing image sha256:6c143c9c97983d865a620b62941cd47c84c2e3c2e6a6ea85938a788e07ecc852
#18 writing image sha256:6c143c9c97983d865a620b62941cd47c84c2e3c2e6a6ea85938a788e07ecc852 done
#18 naming to docker.io/exercism/groovy-test-runner done
#18 DONE 0.2s
Using temporary directory: /var/folders/ml/d832kdw50ms20v_m0zdv6xw80000gp/T/tmp.dqnY0V7nDQ
accumulate: testing...
accumulate: done
acronym: testing...
acronym: done
all-your-base: testing...
all-your-base: done
allergies: testing...
allergies: done
anagram: testing...
anagram: done
armstrong-numbers: testing...
armstrong-numbers: done
atbash-cipher: testing...
atbash-cipher: done
bank-account: testing...
bank-account: done
binary-search: testing...
binary-search: done
bob: testing...
bob: done
circular-buffer: testing...
circular-buffer: done
collatz-conjecture: testing...
collatz-conjecture: done
darts: testing...
darts: done
difference-of-squares: testing...
difference-of-squares: done
dnd-character: testing...
dnd-character: done
eliuds-eggs: testing...
eliuds-eggs: done
etl: testing...
etl: done
flatten-array: testing...
flatten-array: done
gigasecond: testing...
gigasecond: done
grains: testing...
grains: done
hamming: testing...
hamming: done
hello-world: testing...
hello-world: done
high-scores: testing...
high-scores: done
isbn-verifier: testing...
isbn-verifier: done
isogram: testing...
isogram: done
largest-series-product: testing...
largest-series-product: done
leap: testing...
leap: done
linked-list: testing...
linked-list: done
list-ops: testing...
list-ops: done
luhn: testing...
luhn: done
matching-brackets: testing...
matching-brackets: done
matrix: testing...
matrix: done
nth-prime: testing...
nth-prime: done
nucleotide-count: testing...
nucleotide-count: done
pangram: testing...
pangram: done
pascals-triangle: testing...
pascals-triangle: done
perfect-numbers: testing...
perfect-numbers: done
phone-number: testing...
phone-number: done
pig-latin: testing...
pig-latin: done
prime-factors: testing...
prime-factors: done
protein-translation: testing...
protein-translation: done
proverb: testing...
proverb: done
queen-attack: testing...
queen-attack: done
raindrops: testing...
raindrops: done
resistor-color: testing...
resistor-color: done
resistor-color-duo: testing...
resistor-color-duo: done
resistor-color-trio: testing...
resistor-color-trio: done
reverse-string: testing...
reverse-string: done
rna-transcription: testing...
rna-transcription: done
robot-name: testing...
robot-name: done
robot-simulator: testing...
robot-simulator: done
roman-numerals: testing...
roman-numerals: done
rotational-cipher: testing...
rotational-cipher: done
run-length-encoding: testing...
run-length-encoding: done
saddle-points: testing...
saddle-points: done
scrabble-score: testing...
scrabble-score: done
secret-handshake: testing...
secret-handshake: done
series: testing...
series: done
sieve: testing...
sieve: done
space-age: testing...
space-age: done
square-root: testing...
square-root: done
strain: testing...
strain: done
sum-of-multiples: testing...
sum-of-multiples: done
triangle: testing...
triangle: done
two-fer: testing...
two-fer: done
word-count: testing...
word-count: done
yacht: testing...
yacht: done
✅ All tests passed

Latest available stable openJDK
@artamonovkirill artamonovkirill requested a review from a team as a code owner January 18, 2025 17:25
Copy link

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Jan 18, 2025
@SleeplessByte
Copy link
Member

I can't reopen this, but it's a good change!

@artamonovkirill
Copy link
Contributor Author

artamonovkirill commented Jan 18, 2025

I can't reopen this, but it's a good change!

I skipped 17 and went straight to current LTS here: #43
Some context about skipping 17: http://forum.exercism.org/t/upgrading-groovy-and-java/14319/10

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants