Skip to content

Add missing assertion from updateDialingCode test #2916

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 26, 2025

Conversation

gigaSproule
Copy link
Contributor

pull request

I noticed that the new map concept had a test with a missing assertion. I'm assuming this is the expected outcome based on the test name.


Reviewer Resources:

Track Policies

@gigaSproule gigaSproule changed the title Add missin assertion from updateDialingCode test Add missing assertion from updateDialingCode test Feb 25, 2025
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

Copy link
Member

@kahgoh kahgoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's a good spot! Thanks for raising the PR to fix!

@kahgoh kahgoh added the x:size/tiny Tiny amount of work label Feb 26, 2025
@kahgoh kahgoh merged commit 884488d into exercism:main Feb 26, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/tiny Tiny amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants