-
-
Notifications
You must be signed in to change notification settings - Fork 706
Update introduction.md in International Calling Connoisseur #2917
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Removed "studentScores", which seems to be there by mistake.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for taking the time to raise this PR! Your suggested change looks good!
While reviewing, I noticed there were additional problems in the same area and I was wondering if we could fix them 🙏? I left comments to guide you through them.
exercises/concept/international-calling-connoisseur/.docs/introduction.md
Outdated
Show resolved
Hide resolved
exercises/concept/international-calling-connoisseur/.docs/introduction.md
Outdated
Show resolved
Hide resolved
…oduction.md Co-authored-by: Kah Goh <[email protected]>
…oduction.md Co-authored-by: Kah Goh <[email protected]>
Added links to the bottom of the file
Fixed typos, added links for Map keySet and values
Aligned spaces
Fixes typos, added links, aligned spacing
Fixed typos, added links for maps keySet and values, aligned spacing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into the other errors and fixing them in the other files!
removing "studentScores" Co-authored-by: Kah Goh <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks again for taking the time to fix these issues!
@kadrisamuel, Github's branch checking seems to be broken and its not allowing me to merge. I think it might be because there have been changes changes to the main branch since your branch. Could you see if you can update your branch? |
@kahgoh It seems you were right, it should be up to date now. Thanks for the guidance! |
Removed "studentScores", which seems to be there by mistake.
pull request
Reviewer Resources:
Track Policies