Skip to content

Updating test.toml for Flatten-Array #2928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Mar 18, 2025

Conversation

jagdish-15
Copy link
Contributor

Pull Request

@kahgoh, I noticed that the test descriptions were changed after this discussion. I'm unsure whether the changes were only meant to update the test descriptions and the introduction.md file or if they were intended to modify the entire exercise structure—specifically, replacing lists with arrays and requiring a flatten function that accepts an arbitrarily nested array.

Since Java does not support arrays containing mixed data types (like in dynamically typed languages), I assume these updates are just documentation changes. Let me know what you think!


Reviewer Resources:

Track Policies

@kahgoh
Copy link
Member

kahgoh commented Mar 17, 2025

This exercise is a bit problematic since we've used Lists instead of arrays and it looks like the problem specs were updated to just say arrays. I think to allow us to resync this exercise (along with the instructions), I'd suggest addding an instructions.append.md to explain we're using a list instead of an array. It doesn't seem right to just update the test.toml because it changes the test description to use the word "array' instead of "list".

@jagdish-15
Copy link
Contributor Author

@kahgoh, I've synced the docs for this exercise with problem-specifications and added instructions.append.md as requested. Let me know what the heading for this file should be, as it's required by Lint!

@kahgoh kahgoh added the x:size/small Small amount of work label Mar 18, 2025
@kahgoh kahgoh merged commit 5e96674 into exercism:main Mar 18, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
x:size/small Small amount of work
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants