Skip to content

Add tests to check when a language is added several times #2942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

ValMati
Copy link

@ValMati ValMati commented Apr 28, 2025

  • Test that verifies that a language added twice is counted only once
  • Test that proves that a language added twice is correctly deleted

pull request

Although it is not made explicit in the exercise, I believe that it should be understood that a language should be added only once.

Looking forward to your feedback. :)


Reviewer Resources:

Track Policies

- Test that verifies that a language added twice is counted only once
- Test that proves that a language added 2 times is correctly deleted
Copy link
Contributor

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@kahgoh
Copy link
Member

kahgoh commented Apr 28, 2025

I am going to decline this one. I don't see the point in adding this requirement. This is an exercise on Lists. In Java, if you want a collection where each item can be appear only once, I'd suggest using a Set instead.

1 similar comment
@kahgoh
Copy link
Member

kahgoh commented Apr 28, 2025

I am going to decline this one. I don't see the point in adding this requirement. This is an exercise on Lists. In Java, if you want a collection where each item can be appear only once, I'd suggest using a Set instead.

@kahgoh kahgoh closed this Apr 28, 2025
@kahgoh kahgoh closed this Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants