Skip to content

sync connect #865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mk-mxp merged 2 commits into from
Dec 24, 2024
Merged

sync connect #865

mk-mxp merged 2 commits into from
Dec 24, 2024

Conversation

@tomasnorre
Copy link
Contributor

@tomasnorre tomasnorre commented Nov 17, 2024

Resolves #851

@github-actions
Copy link

github-actions bot commented Nov 17, 2024

This PR touches files which potentially affect the outcome of the tests of an exercise. This will cause all students' solutions to affected exercises to be re-tested.

If this PR does not affect the result of the test (or, for example, adds an edge case that is not worth rerunning all tests for), please add the following to the merge-commit message which will stops student's tests from re-running. Please copy-paste to avoid typos.

[no important files changed]

For more information, refer to the documentation. If you are unsure whether to add the message or not, please ping @exercism/maintainers-admin in a comment. Thank you!

@tomasnorre tomasnorre added x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:type/content Work on content (e.g. exercises, concepts) x:size/small Small amount of work x:rep/small Small amount of reputation labels Nov 17, 2024
@tomasnorre tomasnorre marked this pull request as ready for review November 17, 2024 14:39
@tomasnorre tomasnorre requested a review from mk-mxp November 19, 2024 11:26
@mk-mxp
Copy link
Contributor

mk-mxp commented Dec 8, 2024

See #851 for things to decide before going on.

tomasnorre
tomasnorre commented Dec 21, 2024
View reviewed changes
@tomasnorre
Copy link
Contributor Author

tomasnorre commented Dec 21, 2024

I hope I understood the feedback correctly.

mk-mxp
mk-mxp approved these changes Dec 24, 2024
View reviewed changes
Copy link
Contributor

@mk-mxp mk-mxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well done! Thanks a lot for making this happen.

Merry christmas and a happy new year!

@mk-mxp mk-mxp merged commit 0d967cf into exercism:main Dec 24, 2024
12 checks passed
@tomasnorre
Copy link
Contributor Author

tomasnorre commented Dec 26, 2024

Well done! Thanks a lot for making this happen.

Merry christmas and a happy new year!

Thanks you too.

@tomasnorre tomasnorre deleted the sync-connect branch December 26, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mk-mxp mk-mxp mk-mxp approved these changes

Assignees

@tomasnorre tomasnorre

Labels

x:action/sync Sync content with its latest version x:knowledge/elementary Little Exercism knowledge required x:module/practice-exercise Work on Practice Exercises x:rep/small Small amount of reputation x:size/small Small amount of work x:type/content Work on content (e.g. exercises, concepts)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Sync connect

2 participants

@tomasnorre @mk-mxp