Skip to content

Fix appended instructions for Say exercise #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 17, 2025

Conversation

software-artificer
Copy link
Contributor

@software-artificer software-artificer commented Apr 17, 2025

The "Say" exercise contains the statement that is not true, at least no longer:

There is a -1 version of a test case, but it is commented out. If your function is implemented properly, the -1 test case should not compile.

Remove this paragraph to avoid confusion.

The "Say" exercise contains the statement that is not true, at least no
longer:

> There is a -1 version of a test case, but it is commented out. If your
> function is implemented properly, the -1 test case should not compile.

Remove this paragraph to avoid confusion.
Copy link
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions bot closed this Apr 17, 2025
@senekor senekor reopened this Apr 17, 2025
@senekor
Copy link
Contributor

senekor commented Apr 17, 2025

The regression was introduced in #1773

@@ -8,9 +8,6 @@ errors for out of range, we are using Rust's strong type system to limit
input. It is much easier to make a function deal with all valid inputs,
rather than requiring the user of your module to handle errors.

There is a -1 version of a test case, but it is commented out.
If your function is implemented properly, the -1 test case should not compile.

Adding 'and' into number text has not been implemented in test cases.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is also no more test case with "and" as input upstream, so let's remove this line as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dropped that one as well, thank you!

There are no more test cases that have `and` word in the upstream, so we
don't need this sentence either.
Copy link
Contributor

@senekor senekor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@senekor senekor merged commit a64178c into exercism:main Apr 17, 2025
@software-artificer software-artificer deleted the fix-say-docs branch April 17, 2025 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants