Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dnd character exercise #116

Merged
merged 3 commits into from
Apr 19, 2024
Merged

Conversation

SimaDovakin
Copy link
Contributor

@ErikSchierboom @rlmark, for #48in24. I adapted the Haskell implementation.

@rlmark
Copy link
Contributor

rlmark commented Apr 16, 2024

Wow! Thank you! We love DND at Unison.

It looks like that test is failing the transcripts, and I think I see a quick thing to try:

The transcript is looking for a term called dndCharacter.tests which it renames to tests in this file:

https://github.com/exercism/unison/blob/03ca68c15432bcb2f2bdbca2cc1f79a9a0c37403/exercises/practice/dnd-character/.meta/testLoader.md

This term brings together all the tests into one easily runnable function for Unison. Check out how all the tests for allergies get combined in a list in this file for an idea:

https://github.com/exercism/unison/blob/main/exercises/practice/allergies/allergies.test.u

@SimaDovakin
Copy link
Contributor Author

SimaDovakin commented Apr 17, 2024

Thank you for your guidance! I just didn't read the documentation about testing in Unison thoroughly. I had a problem with the verify function and realized that, maybe, there is no one in this UCM version. So I decided to use base.test.gen to generate seed for Random.lcg.

Now, I'm going to clean up the implementation a little bit.

- Fixed tests.
- Added new contributor.
@ErikSchierboom
Copy link
Member

@SimaDovakin Great work! I'll let @rlmark handle the rest.

Copy link
Contributor

@rlmark rlmark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Thank you @SimaDovakin

@rlmark rlmark merged commit 9fc903a into exercism:main Apr 19, 2024
2 checks passed
@SimaDovakin SimaDovakin deleted the dnd-character-exercise branch April 19, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants