fix: use official mlx==0.31.1 from PyPI instead of custom git fork#1950
Closed
jmalekos wants to merge 1 commit intoexo-explore:mainfrom
Closed
fix: use official mlx==0.31.1 from PyPI instead of custom git fork#1950jmalekos wants to merge 1 commit intoexo-explore:mainfrom
jmalekos wants to merge 1 commit intoexo-explore:mainfrom
Conversation
The [tool.uv.sources] override for mlx pointed to a custom dev fork (rltakashige/mlx-jaccl-fix-small-recv) that predates macOS 26 Tahoe's Metal shader requirements. This caused "unknown type name bfloat16_t / complex64_t" errors when loading MLX models on macOS 26. mlx==0.31.1 ships mlx-metal==0.31.1 which includes the correct Metal shaders for macOS 26, so the PyPI release is now sufficient and the git fork override is no longer needed. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Member
|
please raise an issue if one exists, not everything in our fork has been upstreamed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
[tool.uv.sources]override that pointedmlxat a custom dev fork (rltakashige/mlx-jaccl-fix-small-recv, branchaddress-rdma-gpu-locks)uv.locknow resolvesmlx==0.31.1+mlx-metal==0.31.1from PyPIWhy
The custom fork predates macOS 26 Tahoe's updated Metal toolchain. On macOS 26, loading any MLX model produced:
mlx==0.31.1(released on PyPI) shipsmlx-metal==0.31.1which includes Metal shaders compiled against the macOS 26 SDK. The fix the custom fork was carrying is now upstream in the official release.Test plan
uv syncresolvesmlx==0.31.1from PyPI (no git checkout)Metal OK: [[7.0, 10.0], [15.0, 22.0]]uv run pytest)🤖 Generated with Claude Code