Skip to content

Change ownership if the parameters specified - #46

Merged
akremenetsky merged 1 commit into
masterfrom
feat/migrate-to-persist-change-ownership
Jul 9, 2026
Merged

Change ownership if the parameters specified#46
akremenetsky merged 1 commit into
masterfrom
feat/migrate-to-persist-change-ownership

Conversation

@akremenetsky

Copy link
Copy Markdown
Member

No description provided.

@akremenetsky akremenetsky self-assigned this Jul 9, 2026
@akremenetsky
akremenetsky requested a review from a team as a code owner July 9, 2026 08:29

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a change to apply ownership overrides to a persistent directory during bootstrap, even if the directory already exists. The review feedback points out two critical issues: first, the script will skip applying ownership if only one of the override variables (user or group) is provided; second, the script could crash if the persistent directory does not exist, as chown is called without checking directory existence. A robust code suggestion is provided to handle partial ownership parameters and verify the directory's existence before running chown.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread exordos/images/exordos_base/lib/lib_bootstrap.sh
Signed-off-by: Anton Kremenetsky <anton.kremenetsky@gmail.com>
@akremenetsky
akremenetsky force-pushed the feat/migrate-to-persist-change-ownership branch from 88986b4 to 9b5f6e9 Compare July 9, 2026 09:03
@akremenetsky
akremenetsky merged commit e7f638e into master Jul 9, 2026
1 check passed
@akremenetsky
akremenetsky deleted the feat/migrate-to-persist-change-ownership branch July 9, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants