Fix/245 hypervisor connection uri validation by atin65536 · Pull Request #249 · exordos/exordos_core

atin65536 · 2026-03-02T08:27:23Z

No description provided.

gemini-code-assist · 2026-03-02T08:27:39Z

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a critical fix by implementing robust validation for hypervisor connection URIs. It introduces a database migration to ensure that MachinePool objects have unique connection URIs, preventing data inconsistencies. To thoroughly verify this new constraint, the PR also includes a comprehensive refactoring of the functional testing framework, providing more structured and reliable methods for managing test databases and migrations, and adds a dedicated test suite to validate the uniqueness logic under diverse conditions.

Highlights

Database Migration for Unique Connection URI: A new migration was introduced to enforce uniqueness on the 'connection_uri' field within the 'driver_spec' JSONB column of the 'machine_pools' table. This includes a new SQL function to_jsonb_safe to handle potential invalid JSONB conversions gracefully during indexing.
Refactored Functional Test Utilities: The genesis_core/tests/functional/utils.py file was significantly refactored to introduce TestDBManager and TestMigrationManager classes. These provide standardized and improved context managers and helper functions for setting up and tearing down test databases and applying/rolling back migrations.
New Functional Test for Machine Pool Connection URI Validation: A new functional test file genesis_core/tests/functional/dm/test_machine_pool.py was added. This test specifically validates the new unique constraint on the connection_uri for MachinePool objects, covering various scenarios including null, empty, and duplicate URIs.
Enhanced Pytest Fixtures: New pytest fixtures (main_db_url, test_db_name, test_db_url, test_db, test_migrations_manager, test_session) were added to genesis_core/tests/functional/conftest.py. These fixtures leverage the newly refactored TestDBManager and TestMigrationManager to streamline database and migration setup for functional tests.

Changelog

genesis_core/tests/functional/conftest.py
- Added new pytest fixtures for database and migration setup, utilizing the new TestDBManager and TestMigrationManager.
genesis_core/tests/functional/dm/test_machine_pool.py
- Added a new functional test file to validate the unique connection URI constraint for machine pools, covering various input scenarios.
genesis_core/tests/functional/utils.py
- Refactored and extended database and migration test utility classes, introducing TestDBManager and TestMigrationManager for improved test infrastructure.
- Added patch_engines_default context manager to allow patching the default engine for tests.
migrations/0053-unique-machine-pool-connection-uri-d16cdd.py
- Introduced a new database migration to create a unique index on the connection_uri field within the driver_spec JSONB column of the machine_pools table.
- Added a to_jsonb_safe SQL function to handle invalid JSONB conversions gracefully during index creation.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	`/gemini review`	Performs a code review for the current pull request in its current state.
Pull Request Summary	`/gemini summary`	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	`/gemini help`	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist

Code Review

This pull request introduces a database migration to enforce a unique constraint on the connection_uri for hypervisors, preventing duplicate entries. New functional tests are added to validate this constraint, covering various scenarios including null and duplicate values. The testing infrastructure is also enhanced with new fixtures and utility classes in conftest.py and utils.py for better database and migration management during tests.

The changes are well-structured and effectively implement the desired validation. My review includes a couple of suggestions for the new test utilities in genesis_core/tests/functional/utils.py to improve robustness and adherence to best practices regarding database query construction and interaction with third-party library internals.

gemini-code-assist · 2026-03-02T08:31:29Z

+
+    def teardown(self) -> None:
+        if isinstance(self._engine, engines.PgSQLEngine):
+            self._engine._pool.close()


Accessing the private attribute _pool directly is brittle and couples this test utility to the internal implementation of PgSQLEngine. It's better to use a public API for closing the connection pool if one exists. This will make the code more robust to changes in the underlying library.

Engine doesn't have a close method. Pool closing occurs in __del__, which is somewhat hacky and requires a mandatory call to the garbage collector. It looks like there are issues with the Engine lifecycle.

gmelikov · 2026-03-03T07:25:43Z

+                BEGIN
+                    RETURN t::jsonb;
+                EXCEPTION
+                    WHEN invalid_text_representation THEN


I thought about why do we need such function, and looks like the answer is that driver_spec is not a jsonb field. Mayeb convert it to jsonb, so if it's not valid - we won't have a trash in DB @akremenetsky ?

driver_spec field will be validated in RA already https://github.com/infraguys/genesis_core/blob/master/genesis_core/compute/dm/models.py#L147 (but it uses old way to work with json fields, that's why it's varchar in DB).

It's not a blocker for this PR, but looks like a tech debt.

Closes #245

gemini-code-assist Bot reviewed Mar 2, 2026

View reviewed changes

atin65536 requested review from a team, akremenetsky, gmelikov and phantomii and removed request for a team March 3, 2026 03:47

gmelikov reviewed Mar 3, 2026

View reviewed changes

akremenetsky mentioned this pull request Mar 3, 2026

Transfer DB fixtures from GC infraguys/restalchemy#82

Open

gmelikov force-pushed the master branch from 9092418 to b21301e Compare March 17, 2026 13:31

+ introduce MachinePool "connection_uri" unique index.

8a61ecc

Closes #245

atin65536 force-pushed the fix/245-hypervisor-connection-uri-validation branch from 73457c9 to 8a61ecc Compare March 22, 2026 15:57

gmelikov requested a review from slashburygin as a code owner May 16, 2026 17:41

slashburygin closed this Jul 1, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix/245 hypervisor connection uri validation - #249

Fix/245 hypervisor connection uri validation#249
atin65536 wants to merge 1 commit into
masterfrom
fix/245-hypervisor-connection-uri-validation

atin65536 commented Mar 2, 2026

Uh oh!

gemini-code-assist Bot commented Mar 2, 2026

Uh oh!

gemini-code-assist Bot left a comment

Uh oh!

gemini-code-assist Bot Mar 2, 2026

Uh oh!

atin65536 Mar 2, 2026 •

edited

Loading

Uh oh!

Uh oh!

gmelikov Mar 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

atin65536 commented Mar 2, 2026

Uh oh!

gemini-code-assist Bot commented Mar 2, 2026

Summary of Changes

Highlights

Footnotes

Uh oh!

gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

Code Review

Uh oh!

gemini-code-assist Bot Mar 2, 2026

Choose a reason for hiding this comment

Uh oh!

atin65536 Mar 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

gmelikov Mar 3, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

atin65536 Mar 2, 2026 •

edited

Loading