update swagger and add it to docs - #259
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the project's documentation by integrating the OpenAPI specification directly into the MkDocs site. This change makes the User API documentation more accessible and dynamic for developers, ensuring that API specifications are easily viewable alongside other project documentation. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request updates the Swagger/OpenAPI specification and integrates it into the documentation using the mkdocs-render-swagger-plugin. The changes involve adding the plugin to pyproject.toml, including the OpenAPI specification in mkdocs.yml navigation, and creating a markdown file to display the Swagger UI. I have added a review comment to address a missing dependency.
| "pytest-xdist[psutil]>=3.6.1,<4.0.0", # MIT License (MIT) | ||
| "pytest-timer>=1.0.0,<2.0.0", # MIT License (MIT) | ||
| "dnspython>=2.6.0,<3.0.0", # ISC License | ||
| "ruamel-yaml==0.17.26", |
There was a problem hiding this comment.
The ruamel-yaml dependency is added to the test group. While it might be used in tests, it's more directly related to the mkdocs-render-swagger-plugin which uses it to parse YAML files. It would be more appropriate to include it in the docs group to ensure it's available when building the documentation.
Consider moving this dependency to the docs group.
"dnspython>=2.6.0,<3.0.0", # ISC License
]
docs = [
"mkdocs-material==9.1.0",
"mkdocs-glightbox",
"mkdocs-render-swagger-plugin",
"ruamel-yaml==0.17.26",
]
No description provided.