Skip to content

validate exports/imports - #290

Merged
slashburygin merged 5 commits into
masterfrom
validate_tests
Apr 10, 2026
Merged

validate exports/imports#290
slashburygin merged 5 commits into
masterfrom
validate_tests

Conversation

@slashburygin

Copy link
Copy Markdown
Contributor

No description provided.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several example manifest files for testing invalid exports, imports, and resources, alongside a new functional test for the ElementManagerBuilder. The review feedback suggests renaming the test class to maintain consistency with the service being tested and removing unused fixtures from the test method to improve code cleanliness.

Comment thread genesis_core/tests/functional/service/test_elements.py Outdated
Comment thread genesis_core/tests/functional/service/test_elements.py
@slashburygin
slashburygin marked this pull request as ready for review April 6, 2026 06:56
@slashburygin
slashburygin force-pushed the validate_tests branch 8 times, most recently from bee4028 to 8b2625a Compare April 9, 2026 08:20
slashburygin and others added 4 commits April 9, 2026 11:23
Comment thread genesis/images/bootstrap.sh Outdated
@slashburygin
slashburygin merged commit 44994d3 into master Apr 10, 2026
19 checks passed
@slashburygin
slashburygin deleted the validate_tests branch April 10, 2026 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants