Skip to content

add all resources route, update docs, add cron for creating elements inventory - #296

Merged
slashburygin merged 1 commit into
masterfrom
all_resource_route
Apr 16, 2026
Merged

add all resources route, update docs, add cron for creating elements inventory#296
slashburygin merged 1 commit into
masterfrom
all_resource_route

Conversation

@slashburygin

Copy link
Copy Markdown
Contributor

No description provided.

Comment thread .github/workflows/inventory.yml Fixed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces several documentation updates, including a new basic usage guide and certificate management details. It also adds a new global resources endpoint to the Element Manager API, a script for merging element inventories, and improvements to the bootstrap process such as proper file ownership and shell command execution. Feedback focuses on correcting invalid JSON in documentation examples, improving the robustness of the inventory script, and enhancing security by replacing os.system with subprocess.run.

Comment thread docs/usage/basic_usage.md
Comment thread genesis_core/cmd/bootstrap.py
Comment thread genesis_core/cmd/elements_inventory.py Outdated
Comment thread genesis_core/cmd/elements_inventory.py Outdated
Comment thread genesis_core/cmd/elements_inventory.py Outdated
@gmelikov

Copy link
Copy Markdown
Member

toute

@slashburygin
slashburygin force-pushed the all_resource_route branch 2 times, most recently from 0d4adc5 to 5889cb2 Compare April 14, 2026 10:59
@slashburygin slashburygin changed the title add all resources toute, update docs add all resources route, update docs Apr 14, 2026
@slashburygin
slashburygin marked this pull request as ready for review April 14, 2026 11:00
@slashburygin slashburygin changed the title add all resources route, update docs add all resources route, update docs, add cron for creating elements inventory Apr 14, 2026
@slashburygin
slashburygin force-pushed the all_resource_route branch 9 times, most recently from 4278ce5 to a42d841 Compare April 14, 2026 13:00
Comment thread genesis_core/user_api/em/api/controllers.py
@slashburygin
slashburygin merged commit 4fb1047 into master Apr 16, 2026
19 checks passed
@slashburygin
slashburygin deleted the all_resource_route branch April 16, 2026 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants