add openapi spec to manifests and link from element to manifest - #314
Merged
Conversation
slashburygin
requested review from
akremenetsky,
gmelikov and
phantomii
as code owners
May 1, 2026 04:20
slashburygin
force-pushed
the
openapi_spec
branch
2 times, most recently
from
May 1, 2026 04:23
8963b29 to
31f3997
Compare
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the OpenAPI specifications by adding openapi_spec and manifest fields, introducing new resource schemas, and removing several required fields across various models. It also upgrades the restalchemy dependency and includes a database migration. The core logic is modified to support dynamic schema construction from external URLs. A critical security vulnerability was identified in the build_full_schema function, which is susceptible to Server-Side Request Forgery (SSRF) due to insufficient validation of fetched specifications.
slashburygin
force-pushed
the
openapi_spec
branch
11 times, most recently
from
May 5, 2026 13:16
0a6be19 to
c670a7e
Compare
gmelikov
approved these changes
May 5, 2026
phantomii
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.