Skip to content

Try to remove free agents on element removal - #372

Open
gmelikov wants to merge 1 commit into
masterfrom
clean_agents
Open

Try to remove free agents on element removal#372
gmelikov wants to merge 1 commit into
masterfrom
clean_agents

Conversation

@gmelikov

@gmelikov gmelikov commented Jun 3, 2026

Copy link
Copy Markdown
Member

It's a hotfix, but should do the trick for some time.

@gmelikov
gmelikov requested a review from a team as a code owner June 3, 2026 17:13

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds console boot parameters to the iPXE kernel template and implements garbage collection for orphaned UniversalAgent instances when deleting an Element. A critical bug was identified in the garbage collection logic: checking the truthiness of the generator returned by get_all() will always evaluate to True, which prevents orphaned agents from ever being deleted. Materializing the generator into a list or using any() is required to fix this issue.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread exordos_core/elements/dm/models.py
It's a hotfix, but should do the trick for some time.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant