Try to remove free agents on element removal - #372
Conversation
There was a problem hiding this comment.
Code Review
This pull request adds console boot parameters to the iPXE kernel template and implements garbage collection for orphaned UniversalAgent instances when deleting an Element. A critical bug was identified in the garbage collection logic: checking the truthiness of the generator returned by get_all() will always evaluate to True, which prevents orphaned agents from ever being deleted. Materializing the generator into a list or using any() is required to fix this issue.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
It's a hotfix, but should do the trick for some time.
It's a hotfix, but should do the trick for some time.