Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces a fast retry cadence for the telemetry service until registration is successful, and implements automatic personal workspace provisioning for users upon email confirmation based on their registration client. It also includes corresponding unit and functional tests, database migrations, and a downgrade fix for an older migration. The review feedback highlights two critical issues: a typo in the migration base class name (AbstarctMigrationStep instead of AbstractMigrationStep) that will cause an AttributeError, and an exception handling mismatch in the controller where iam_e.InvalidAuthTokenError is raised but only gcl_iam_e.InvalidAuthTokenError is caught, potentially leading to uncaught 500 errors during anonymous registration.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
|
Duplicates #443 ? |
2a81757 to
03d6fe9
Compare
cassi-volkova
left a comment
cassi-volkova
left a comment
There was a problem hiding this comment.
Tested commit 03d6fe9. The PR is not currently deployable: both the image build and functional-test setup fail before the telemetry behavior can be exercised because the migration graph has two heads.
TelemetryService only retried every iter_min_period (up to 1 hour), but exordos-bootstrap sets the VS variables it depends on with no systemd ordering guarantee relative to ec-gservice, so the very first attempt can silently skip (variables not set yet). With a 1-hour retry period, a managed realm's ecosystem-side provisioning_timeout (also defaulting to 1 hour) can fire before the next attempt, permanently erroring the realm. Retry starting at 30s until registration is confirmed, then relax to the caller's steady-state period immediately. Stands with no network access at all would otherwise retry every 30s forever, so each failed attempt doubles the retry period, capped at the steady-state period, until registration succeeds. Also bump the "variables not configured" log from DEBUG to INFO so this condition is visible in normal logs. Signed-off-by: George Melikov <mail@gmelikov.ru>
4 participants
No description provided.