value_error-> validate_error - #477
Conversation
There was a problem hiding this comment.
Code Review
This pull request updates load balancer names from using underscores to hyphens in the manifest files, and replaces standard ValueError exceptions with a custom exceptions.ValidateException in the repository models. The review feedback highlights several instances in exordos_core/repo/dm/models.py where line breaks immediately following the err= keyword argument assignment reduce readability, suggesting cleaner formatting with code blocks.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
cassi-volkova
left a comment
There was a problem hiding this comment.
The exception contract is changed here, but the repository's own uninstall tests still require ValueError. On this exact head, tox -e develop finishes with 189 passing tests and two failures in test_repo_element_deps_binding.py; the Python 3.10/3.12/3.14 and coverage jobs fail for the same reason.
Expected: the test suite and method documentation consistently assert the new ValidateException contract for every converted validation branch. Actual: both uninstall error scenarios raise ValidateException while their tests still assert ValueError, leaving the PR's required test matrix red. Please update the affected assertions and add/adjust coverage for the other converted install, upgrade, edit, driver-selection, and upload branches so the new public error behavior is intentional and protected.
No description provided.