Skip to content

value_error-> validate_error - #477

Open
slashburygin wants to merge 1 commit into
masterfrom
validate
Open

value_error-> validate_error#477
slashburygin wants to merge 1 commit into
masterfrom
validate

Conversation

@slashburygin

Copy link
Copy Markdown
Contributor

No description provided.

@slashburygin
slashburygin requested a review from a team as a code owner July 13, 2026 21:10

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates load balancer names from using underscores to hyphens in the manifest files, and replaces standard ValueError exceptions with a custom exceptions.ValidateException in the repository models. The review feedback highlights several instances in exordos_core/repo/dm/models.py where line breaks immediately following the err= keyword argument assignment reduce readability, suggesting cleaner formatting with code blocks.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread exordos_core/repo/dm/models.py Outdated
Comment thread exordos_core/repo/dm/models.py Outdated
Comment thread exordos_core/repo/dm/models.py Outdated

@cassi-volkova cassi-volkova left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The exception contract is changed here, but the repository's own uninstall tests still require ValueError. On this exact head, tox -e develop finishes with 189 passing tests and two failures in test_repo_element_deps_binding.py; the Python 3.10/3.12/3.14 and coverage jobs fail for the same reason.

Expected: the test suite and method documentation consistently assert the new ValidateException contract for every converted validation branch. Actual: both uninstall error scenarios raise ValidateException while their tests still assert ValueError, leaving the PR's required test matrix red. Please update the affected assertions and add/adjust coverage for the other converted install, upgrade, edit, driver-selection, and upload branches so the new public error behavior is intentional and protected.

Comment thread exordos_core/repo/dm/models.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants