fix(gservice): remove unused PoolAgentDriver universal agent - #488
Closed
VasilyStepanov wants to merge 1 commit into
Closed
fix(gservice): remove unused PoolAgentDriver universal agent#488VasilyStepanov wants to merge 1 commit into
VasilyStepanov wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request removes the machine_pool_agent initialization, its driver import, and its registration from the service initialization in exordos_core/gservice/service.py. There are no review comments, so we have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
The machine_pool_agent service wired PoolAgentDriver into a UniversalAgentService but nothing consumed its capability, and no docs or tests reference it, so drop the dead wiring from GeneralService.
VasilyStepanov
force-pushed
the
del/poolagentdriver
branch
from
July 16, 2026 14:17
6bd9738 to
20dbb95
Compare
VasilyStepanov
changed the base branch from
master
to
feat/machine-pool-migrate-spec-to-kind
July 16, 2026 14:18
Contributor
Author
|
Will be merged in #494 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The machine_pool_agent service wired PoolAgentDriver into a UniversalAgentService but nothing consumed its capability, and no docs or tests reference it, so drop the dead wiring from GeneralService.