migrate_to_persistent /etc/dnsdist

[slashburygin]

Summary by Sourcery

Enhancements:

• Include /etc/dnsdist in the set of directories migrated to the persistent mount during bootstrap to retain dnsdist configuration across restarts.

[gemini-code-assist]

Caution

The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased.

[sourcery-ai]

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Extend persistent disk migration to include dnsdist configuration under /etc/dnsdist so it survives rebuilds/reboots alongside other system state.

Flow diagram for adding dnsdist to persistent migration

flowchart TD
    A[bootstrap.sh start] --> B{PERSISTENT_DISK set}
    B -->|yes| C[migrate_to_persistent /var/lib/exordos/data]
    C --> D[migrate_to_persistent_stop_start /var/lib/postgresql]
    D --> E[migrate_to_persistent /etc/exordos_core]
    E --> F[migrate_to_persistent /etc/dnsdist]
    F --> G[migrate_to_persistent /home/ubuntu]
    G --> H[migrate_to_persistent /root]
    B -->|no| I[skip persistent migration]

Loading

File-Level Changes

Change	Details	Files
Add migration of dnsdist configuration to the persistent disk during bootstrap.	Invoke migrate_to_persistent for /etc/dnsdist, targeting the corresponding path on the persistent mount. Place the new migration call alongside existing configuration and data migrations to keep ordering and behavior consistent.	exordos/images/bootstrap.sh

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it. You can also reply to a
  review comment with @sourcery-ai issue to create an issue from it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time. You can also comment
  @sourcery-ai title on the pull request to (re-)generate the title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time exactly where you
  want it. You can also comment @sourcery-ai summary on the pull request to
  (re-)generate the summary at any time.
• Generate reviewer's guide: Comment @sourcery-ai guide on the pull
  request to (re-)generate the reviewer's guide at any time.
• Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
  pull request to resolve all Sourcery comments. Useful if you've already
  addressed all the comments and don't want to see them anymore.
• Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
  request to dismiss all existing Sourcery reviews. Especially useful if you
  want to start fresh with a new review - don't forget to comment
  @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey - I've left some high level feedback:

• Consider whether dnsdist should use the stop/start variant of migrate_to_persistent (like PostgreSQL) to avoid potential issues if its configuration directory is moved while the service is running.
• It may be worth ensuring /etc/dnsdist exists before attempting migration, or handling the case where the directory is absent to avoid unnecessary errors during bootstrap.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- Consider whether dnsdist should use the stop/start variant of `migrate_to_persistent` (like PostgreSQL) to avoid potential issues if its configuration directory is moved while the service is running.
- It may be worth ensuring `/etc/dnsdist` exists before attempting migration, or handling the case where the directory is absent to avoid unnecessary errors during bootstrap.

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}