fix(build): resolve gcl_sdk migrations path instead of hardcoding it - #551
Open
VasilyStepanov wants to merge 1 commit into
Open
fix(build): resolve gcl_sdk migrations path instead of hardcoding it#551VasilyStepanov wants to merge 1 commit into
VasilyStepanov wants to merge 1 commit into
Conversation
The path baked in a literal python3.14 site-packages location. That assumption already breaks in the common dev-mode build (LOCAL_GENESIS_SDK_PATH set -> gcl_sdk reinstalled with `pip install -e`), since an editable install has no physical site-packages/gcl_sdk directory at all, only a finder redirecting to the source tree - regardless of python version. Resolve it via gcl_sdk.migrations.__file__ in the already-activated venv instead, which works for both a normal and an editable install.
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideThis PR fixes build-time migration application for gcl_sdk by dynamically resolving the migrations module path via Python instead of hardcoding a site-packages path tied to a specific Python version and installation layout. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
slashburygin
approved these changes
Aug 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
ra-apply-migrationfailing withFileNotFoundErrorwhen applyinggcl_sdk's migrations during the core image build.install.sh/bootstrap.shhardcoded the migrations path as$GC_PATH/.venv/lib/python3.14/site-packages/gcl_sdk/migrations. This breaks in dev-mode builds (LOCAL_GENESIS_SDK_PATHset), wheregcl_sdkis installed editable viapip install -eand no physicalsite-packages/gcl_sdk/directory exists — only a finder redirect to the source tree.Resolve the path dynamically instead:
Works for both a normal and an editable install, and isn't tied to a specific python version.
Summary by Sourcery
Resolve gcl_sdk migration path dynamically during image bootstrap and install to avoid failures in different installation modes.
Bug Fixes:
Build: