Update project dependencies - #28
Conversation
CASSI final dependency validation reportFinal head: The temporary validation source has been removed. The final lock resolves the published gcl_iam 1.3.2 and Cryptography 49.0.0 from PyPI. Verification
RecommendationSafe to merge. The released dependency set resolves cleanly, all dependency-sensitive automated and integration checks pass, and no compatibility workaround remains in the patch. |
There was a problem hiding this comment.
Code Review
This pull request updates project dependencies, including bumping certbot to version 5.x, cryptography to version 49.x, and mock to version 5.x, along with adding a temporary validation source for gcl-iam. It also introduces a new unit test suite (test_dependency_compat.py) to verify compatibility with these updated dependencies. Feedback on the new tests suggests importing mock from the standard library unittest module to align with PEP 8 import grouping, and simplifying public key comparison by comparing the key objects directly instead of using public_numbers().
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
0656166 to
34daf7d
Compare
34daf7d to
93a3f56
Compare
Summary
Combines Dependabot updates #18, #20, #25, and #26 into one tested dependency patch:
gcl_sdk2.0.0 → 3.0.8certbot4.1.1 → 5.6.0mock3.0.5 → 5.2.0cryptography46.0.5 → 49.0.0The patch adds focused compatibility tests for the Certbot authenticator interface, Cryptography RSA key/CSR operations, and the SDK-backed DNS client.
The dependency bridge is complete: gcl_iam 1.3.2 is published with Python 3.10+ and Cryptography 49 support. The final lock resolves the registry release and contains no temporary Git source.
Source review highlights
CoreIamAuthenticatorandCollectionBaseClient; both are covered by compatibility tests and isolated integration validation.Validation
Tested commit:
93a3f565b0c6baa8b2e5e973f94a4880787a6369.gcl_iam 1.3.2and Cryptography 49.0.0 from PyPI.genesis-coreas an Authenticator.masterbaseline: 11 errors in 2 files.masterbecause the functional-test directory does not exist.Result
The released dependency set is compatible and this PR is ready for review.