aiservices cli improvements #766
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…goscale utilities
habfast
force-pushed
the
paul.habfast/sc-151282_aiservices-cli-improvements
branch
from
4955a0f to
3061ab1
Compare
aureliar8
reviewed
Nov 26, 2025
Comment on lines
48
to
54
| if err != nil { | ||
| return | ||
| } | ||
| err = r.Body.Close() | ||
| if err != nil { | ||
| return | ||
| } |
Contributor
There was a problem hiding this comment.
If you want you can t.Fail() here
cmd/aiservices/deployment/helpers.go
Outdated
| @@ -0,0 +1,3 @@ | |||
| package deployment | |||
Contributor
Author
There was a problem hiding this comment.
Oops I thought I had done it 👀 . Absolutely
| Replicas int64 `json:"replicas"` | ||
| ServiceLevel string `json:"service_level"` | ||
| DeploymentURL string `json:"deployment_url"` | ||
| ModelID *v3.UUID `json:"model_id"` |
Member
There was a problem hiding this comment.
is this one need to be a pointer?
pierre-emmanuelJ
approved these changes
Nov 26, 2025
arapaho
changed the title
habfast
deleted the
paul.habfast/sc-151282_aiservices-cli-improvements
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
shortcut story: sc-151282
Also fixes sc-151025 by bumping egoscale
Checklist
(For exoscale contributors)
Changelog updatedno changes for the usersTesting
simply created and deleted models and instances.